feat ydb: add TopicWriteSession support#1183
Open
vasily-sviridov wants to merge 1 commit intouserver-framework:developfrom
Open
feat ydb: add TopicWriteSession support#1183vasily-sviridov wants to merge 1 commit intouserver-framework:developfrom
vasily-sviridov wants to merge 1 commit intouserver-framework:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TopicClienthad read session support but no write session support, requiring users to callGetNativeTopicClient()directly.This PR adds
TopicWriteSession-- a thin coroutine-friendly wrapper overNYdb::NTopic::IWriteSession, mirroring the existingTopicReadSessionpattern:GetEvent()-- suspends the coroutine viaimpl::GetFutureValue(WaitEvent()), then returns the eventTryGetEvent()-- non-blocking poll, returnsnulloptif no event is bufferedWrite(),Close(),GetNativeTopicWriteSession()-- thin forwarding wrappersTopicClient::CreateWriteSession(const TWriteSessionSettings&)is added alongside the existingCreateReadSessionNote: by creating a PR or an issue you automatically agree to the CLA. See CONTRIBUTING.md. Feel free to remove this note, the agreement holds.